Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fi] Bypass response check #385

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

nasahlpa
Copy link
Member

@nasahlpa nasahlpa commented Dec 6, 2024

This PR consists of the two following commits:

  • Allow tests to bypass the response check
  • Remove expected response from OTBN test config file

@nasahlpa nasahlpa marked this pull request as ready for review December 6, 2024 13:09
For some tests (e.g., that return random data) comparing the response
with an expected response does not make sense. For these tests a
manual analysis needs to be conducted. This commit detects these tests
and bypass the response comparion.

Closes lowRISC#382

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
As this test does return random data on each iteration, remove the
expected response field.

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
@nasahlpa nasahlpa force-pushed the bypass_response_check branch from 9d80bfa to 5a15ef7 Compare December 6, 2024 13:32
@nasahlpa nasahlpa merged commit 26a39dc into lowRISC:master Dec 6, 2024
9 checks passed
@nasahlpa nasahlpa deleted the bypass_response_check branch December 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants