[rom_ext] Boot services refactor and unit tests #27453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowBearVR
force-pushed
the
rom_ext_refactor
branch
2 times, most recently
from
0f7fa3d to
5d5a639
Compare
There was a problem hiding this comment.
Dropped a couple comments. In general mostly LGTM. Thanks for this first submission!
One other improvement that would be useful: could you please add/expand commit messages? Each commit just has a title but no detailed description. See here https://opentitan.org/book/doc/contributing/detailed_contribution_guide/index.html?highlight=commit%20messages#what-should-commit-messages-look-like for some guidelines, and also it can be useful to take a look at other commit messages in the repo already.
sw/device/silicon_creator/rom_ext/rom_ext_boot_services_unittest.cc
Outdated
Show resolved
Hide resolved
ShadowBearVR
force-pushed
the
rom_ext_refactor
branch
from
5d5a639 to
a85d6ea
Compare
In preparation for fuzzing efforts, all boot services related code in rom_ext has been refactored into a seperate library. This will allow unit tests, and fuzz tests, to run this code directly on the host by removing device dependencies. The majority of code changes in this commit are due to moving code from one file to another. Signed-off-by: Collin MacDonald <cmacd@google.com>
This change converts the owner_verify library into a dual library, with support for running both on device and host targets. Additionally, this change adds the required mocks to allow hosts to run owner_verify. Signed-off-by: Collin MacDonald <cmacd@google.com>
This change expands the existing Manifest mock to include support for three additional methods: manifest_ext_get_spx_key, manifest_ext_get_spx_signature, and manifest_ext_get_isfb. Future unit tests will use each of these methods. Signed-off-by: Collin MacDonald <cmacd@google.com>
When running on a host target, the rescue type is undefined, as it is currently only defined on a per device basis. This change adds a NULL rescue type to be used by future unit tests. Signed-off-by: Collin MacDonald <cmacd@google.com>
This change adds conditional compilation flags to dbg_print related functions to better support on host unit tests. Additionally, to support existing dbg_print unit tests, a unit test specific flag was added. Signed-off-by: Collin MacDonald <cmacd@google.com>
This change adds 7 initial tests for boot services with basic parameters for each. These tests serve as a starting point for more complex unit tests and fuzzing tests related to boot services. Signed-off-by: Collin MacDonald <cmacd@google.com>
This change fills out the BootSvcEnterRescue, BootSvcOwnershipUnlock, and BootSvcOwnershipActivate unit tests with the required inputs to pass. Signed-off-by: Ellis Sarza-Nguyen <sarzanguyen@google.com>
Adds additional equality checks, formats all unit tests, and ensures similar checks are present in all 7 boot service handler related unit tests. Signed-off-by: Collin MacDonald <cmacd@google.com>
ShadowBearVR
force-pushed
the
rom_ext_refactor
branch
from
a85d6ea to
ad767bb
Compare
timothytrippel
approved these changes
Jun 25, 2025
cfrantz
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes refactor the
handle_boot_svcmethod and several related methods out ofrom_ext.cinto separate libraries -rom_ext_boot_services.candrom_ext_verify.c. This enables standalone unit tests to be written for boot services (and shortly, fuzzing for boot services).Unit tests were added for each action handled in
handle_boot_svc. Mocks and conditional compilation were added where necessary to support on-host tests forrom_ext.