Skip to content

Cherrypick to earlgrey_1.0.0: [ujson] Fix potential unsigned underflow/overflow. #26972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Cherrypick to earlgrey_1.0.0: [ujson] Fix potential unsigned underflow/overflow. #26972

merged 1 commit into from
Apr 22, 2025

Conversation

cehann
Copy link

@cehann cehann commented Apr 15, 2025

@cehann cehann requested a review from a team as a code owner April 15, 2025 01:51
@cehann cehann requested review from pamaury and removed request for a team April 15, 2025 01:51
@timothytrippel timothytrippel self-requested a review April 15, 2025 06:57
@nbdd0121
Copy link
Contributor

Please use -x to cherry-pick so the commit message include SHA of the cherry-picked commit.

@timothytrippel
Copy link
Contributor

@cehann pls fix up the commit message as @nbdd0121 describes above

@cehann cehann force-pushed the cherry-pick-ujson branch from 63e1dc2 to 6b78de6 Compare April 16, 2025 00:21
@cehann
Copy link
Author

cehann commented Apr 16, 2025

@cehann pls fix up the commit message as @nbdd0121 describes above

Done.

@nbdd0121
Copy link
Contributor

Please cherry-pick from the merged commit (71732d1) instead of your feature branch, thanks.

[ujson] Fix potential unsigned underflow/overflow.
aa685c0 
1. The subtraction (c - '\t') might underflow, this commit updates the
   implementation.
2. The `value` in `ujson_parse_interger` might overflow, this commits
   adds a check before the assignment.

Signed-off-by: cehann <shihhanchang@google.com>
(cherry picked from commit 71732d1)
@cehann cehann force-pushed the cherry-pick-ujson branch from 6b78de6 to aa685c0 Compare April 17, 2025 02:23
@cehann
Copy link
Author

cehann commented Apr 17, 2025

Updated. Sorry for being careless, and thanks @nbdd0121 for your patient reply.

@timothytrippel timothytrippel merged commit 0cc2b70 into lowRISC:earlgrey_1.0.0 Apr 22, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbdd0121 nbdd0121 nbdd0121 approved these changes

@timothytrippel timothytrippel timothytrippel approved these changes

@pamaury pamaury Awaiting requested review from pamaury pamaury is a code owner automatically assigned from lowRISC/ot-c-cpp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cehann @nbdd0121 @timothytrippel