Nc fixes #24774
Closed
Nc fixes #24774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a run time issue seen when trying to run otbn tests using VCS When running tests with vcs, the gen_binaries.py script looks for this python library. The fix implemented here adds ninja==1.11.1.1 requirement to pyproject.toml file. The ./util/sh/scripts/gen-python-requirements.sh script was run to update the python-requirements.txt file and the updated python-requirements.txt is added to this commit along with the source pyproject.toml file Signed-off-by: Venkat Krishnan <venkateswarank.opentitan@gmail.com>
This fixes a build issue seen when trying to run otbn tests using VCS The simulator does not allow a class inside a SV package to access components / signals of in a out of scope module block. The workaround in this commit creates a SV interface with no ports and instantiate it in TB. Add a function is added in this interface that can access XMR signals/assertions in TB/DUT hierarchy This interface handle is passed as a virtual interface to the class in SV package using config_db and the function to control XMR signals is accessed sing the virtual interface handle in the class code Signed-off-by: Venkat Krishnan <venkateswarank.opentitan@gmail.com>
Improve stability of batch runs using the nc job scheduler by specifying minimum cpu and ram requiements (CPU, CORES) and an option to skip directory validity check (-D) to prevent triggering false alarms about directory not accessible by all machines in the cluster. Signed-off-by: Venkat Krishnan <venkateswarank.opentitan@gmail.com>
This change removes the -e SNAPSHOT argument to the nc run command to avoid taking snapshots of the current environment for every job. Under heavy load, many NFS servers may not be fast enough to deliver SNAPSHOT files to remote hosts where jobs need to execute. This can cause job failures that are difficult to debug https://2024.help.altair.com/2024.1.0/accelerator/html/ accel/topics/accelerator/env_var_snapshot.htm While there are other advanced methods to capture this information, like SNAPPROP and named environments, this may be an overkill for our use. So removing this feature to keep things simple Signed-off-by: Venkat Krishnan <venkateswarank.opentitan@gmail.com>
For non-interactive jobs, the Nclauncher script writes some initial message into the log file and then forks off a subprocess to initiate the call to the nc scheduler with the same log file pointer for stdout logging. When multiple jobs are run in parallel and the log file resides in a NFS, this seems to cause some clobbering of file handles causing the subprocess to error with a cryptic error message saying socket address already in use. Using a file descriptor can alleviate this problem as they work at a lower level of abstraction and are managed by the kernel and can handle open files across both the parent and child processes.The file descriptor approach is now also extended to the interactive mode which further allows removing redundant code by sharing same logic between interactive and non-interactive modes Signed-off-by: Venkat Krishnan <venkateswarank.opentitan@gmail.com>
The post_cmd feature of nc run was a hook to call a user script with two arguments, the job id and exit code. The user script could return with a different exit code and override the job's exit code. However, the user script that was added originally just printed arguments and exited without modifying anything serving no new purpose. Hence removing to keep things simple Signed-off-by: Venkat Krishnan <venkateswarank.opentitan@gmail.com>
venkatk-ot
requested review from
marnovandermaas
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.