Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sival, keymgr] State-agnostic chip_sw_key_derivation_test #24755

Merged
merged 2 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. [keymgr] Remove unused includes in keymgr_key_derivation_test.c

    Most includes in sw/device/tests/keymgr_key_derivation_test.c are
    superfluous. This commit removes them and updates the corresponding
    Bazel build directive.
    
    Signed-off-by: Andrea Caforio <andrea.caforio@lowrisc.org>
    andrea-caforio committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9076017 View commit details
    Browse the repository at this point in the history
  2. [sival, keymgr] State-agnostic chip_sw_key_derivation_test

    keymgr_key_derivation_test_fpga_cw310_sival_rom_ext test was marked as
    broken in lowRISC#21706. This commit fixes this and addresses lowRISC#21500.
    
    The source of the bug is due to the nature of the ROM_EXT that runs
    through a CDI attestation flow advancing the key manager state to
    "OwnerRootKey" in the process. This was not accounted for in the test,
    which assumed an active "CreatorRootKey" state (this works for sim_dv
    tests but not with ROM_EXT). The solution to this issue lies in
    rendering the test state-agnostic, meaning it will execute its
    verifications independently of the current key manager state. This
    approach thus mimics the keymgr_sideload_{aes,kmac,otbn} tests which
    follow a similar strategy.
    
    Signed-off-by: Andrea Caforio <andrea.caforio@lowrisc.org>
    andrea-caforio committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    aa4031d View commit details
    Browse the repository at this point in the history