[tlul/rtl] Modify readback check error reporting logic #24702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only a readback error check is reported when the `error_i` signal is not raised. However, as this signal is also raised when there is no activity on the TL-UL bus, we might miss some readback failures. This commit modifies the error reporting logic to also report the readback mismatch when the error signal is raised. Closes lowRISC#24698. This is a cherry pick of commit 267e61c to branch earlgrey_1.0.0. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
vogelpi
requested review from
nasahlpa,
andreaskurth,
moidx and
johannheyszl
|
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_sram_byte.sv This is a confirmed ECO which is okay. |
|
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_sram_byte.sv Confirmed ECO. |
nasahlpa
approved these changes
Oct 1, 2024
|
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_sram_byte.sv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only a readback error check is reported when the
error_isignal is not raised. However, as this signal is also raised when there is no activity on the TL-UL bus, we might miss some readback failures.This commit modifies the error reporting logic to also report the readback mismatch when the error signal is raised.
Closes #24698.
This is a cherry pick of PR #24679 to branch earlgrey_1.0.0.