[rules] Specify fusesoc cache dir to be in the bazel tree #23698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the fusesoc cache dir be in the bazel tree, so fusesoc doesn't attempt to create directories outside, such as ~/.cache/fusesoc. That action can cause build failures, since fusesoc is sandboxed. Signed-off-by: Alexander Williams <awill@opentitan.org>
jwnrt
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
I think this would fix #22833 and a bug that @AlexJones0 was having. It LGTM, was there something you wanted to change before marking as ready?
It was merely marked draft because of the quiet period (since it changes something with tool flows, though it should represent a fix, hehe). |
|
I've marked it ready, since the development is ostensibly done, but do check that the merge window for such changes is open before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the fusesoc cache dir be in the bazel tree, so fusesoc doesn't attempt to create directories outside, such as ~/.cache/fusesoc. That action can cause build failures, since fusesoc is sandboxed.
Fixes #23696