Skip to content

[sw] Apply common CMake conventions #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

[sw] Apply common CMake conventions #46

merged 1 commit into from
Jul 7, 2023

Conversation

ianbenz
Copy link
Contributor

@ianbenz ianbenz commented May 1, 2023

  • Set the target compiler and flags in a toolchain file
    • Enhance portability to other toolchains
    • Enable compiler flags to be set in the CMake cache
    • Use the target toolchain instead of the host toolchain for CMake compiler detection
  • Enable assembly language support
  • Simplify linking the common library

marnovandermaas
marnovandermaas reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, it seems to build correctly on my machine. I just added one small question.

@ianbenz
[sw] Apply common CMake conventions
6567fed 
- Set the target compiler and flags in a toolchain file
- Enable assembly language support
- Simplify linking the common library
marnovandermaas
marnovandermaas approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look quite reasonable to me, although I am not a cmake expert. @engdoreis would you mind having a look at these changes before we merge it?

@marnovandermaas marnovandermaas requested a review from engdoreis July 5, 2023 09:36
@engdoreis engdoreis requested a review from luismarques July 5, 2023 10:30
engdoreis
engdoreis approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@engdoreis engdoreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work.

@engdoreis engdoreis merged commit 5afc57e into lowRISC:main Jul 7, 2023
@nuntipat nuntipat mentioned this pull request Jul 7, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marnovandermaas marnovandermaas marnovandermaas approved these changes

@engdoreis engdoreis engdoreis approved these changes

@luismarques luismarques Awaiting requested review from luismarques

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianbenz @marnovandermaas @engdoreis