Skip to content

linux-x64: use rust nightly#283

Merged
lovell merged 1 commit intolovell:mainfrom
kleisauke:rust-nightly-linux-x64
Jul 8, 2025
Merged

linux-x64: use rust nightly#283
lovell merged 1 commit intolovell:mainfrom
kleisauke:rust-nightly-linux-x64

Conversation

@kleisauke
Copy link
Collaborator

Also, forcefully disable gold as the linker, as Rust still seems to emit a warning:
https://github.com/lovell/sharp-libvips/actions/runs/16145634431/job/45563658436#step:4:13810
(though, I think it's safe in that case, since we are building librsvg statically)

Note that we could use export CARGO_PROFILE_RELEASE_TRIM_PATHS="all" as a possible follow-up. However, enabling it isn't very straightforward, since -Ztrim-paths cannot be added to the RUSTFLAGS env variable, see:
https://doc.rust-lang.org/cargo/reference/unstable.html#profile-trim-paths-option

@kleisauke
Copy link
Collaborator Author

Before:

-rw-r--r-- 1 root root 94095574 Jul  8 14:22 librsvg-2.a
-rwxr-xr-x 1 root root 16916968 Jul  8 14:23 libvips-cpp.so.8.17.1

After:

-rw-r--r-- 1 root root 92855122 Jul  8 15:18 librsvg-2.a
-rwxr-xr-x 1 root root 16642544 Jul  8 15:19 libvips-cpp.so.8.17.1

@lovell lovell merged commit 4eec3af into lovell:main Jul 8, 2025
16 checks passed
@lovell
Copy link
Owner

lovell commented Jul 8, 2025

Deleting the file so gcc can't find it... this is comedy gold! 🤣

@kleisauke kleisauke deleted the rust-nightly-linux-x64 branch July 8, 2025 16:12
megantaite pushed a commit to animoto/sharp-libvips that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants