Ensure files are not placed outside install prefix#277
Merged
lovell merged 3 commits intolovell:mainfrom Jun 11, 2025
Merged
Conversation
Owner
|
Thank you, I was rather hasty in my removal of the macOS cross-compilation config, and you're totally right about fontconfig needing these. |
megantaite
pushed a commit
to animoto/sharp-libvips
that referenced
this pull request
Jul 30, 2025
* glib: do not place files outside install prefix * fontconfig: disable install of gettext files * macOS: restore directories removed in 2760713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ec75c96 and 5c27d09 ensures that files are not placed outside the install prefix. This allow us to restore the directories removed in commit 2760713, which are possibly(?) required by Fontconfig to locate system fonts.
Note: upstream PR https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4661 would prevent the
/target/share/localebuild path from being included in the binaries (context: #227 (comment)).