Merged
Conversation
Collaborator
Author
|
We could perhaps backport https://github.com/strukturag/libheif/pull/1330.patch as a follow-up. |
Owner
|
I think there's a new version of libheif imminent - see strukturag/libheif@f396bd7 Not sure why the s390x build is failing, best guess would be some kind of regression in serde (as a librsvg dependency). The most recent passing build - https://github.com/lovell/sharp-libvips/actions/runs/11437971230 This build: |
Collaborator
Author
|
Commit df811a1 should resolve the failing build, which was impacting more than just s390x. It does indeed seem a regression in serde. |
Owner
|
Dankjewel! |
Collaborator
Author
|
For reference, upstream serde issue: serde-rs/serde#2844. |
megantaite
pushed a commit
to animoto/sharp-libvips
that referenced
this pull request
Apr 16, 2025
* cargo-c: ensure deterministic build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.