Skip to content

xml2: switch from autotools to meson#240

Merged
lovell merged 1 commit intolovell:mainfrom
kleisauke:xml2-meson
Jul 9, 2024
Merged

xml2: switch from autotools to meson#240
lovell merged 1 commit intolovell:mainfrom
kleisauke:xml2-meson

Conversation

@kleisauke
Copy link
Collaborator

Before:

-rw-r--r-- 1 root root   878202 Jul  8 09:21 libxml2.a

After

-rw-r--r-- 1 root root   554918 Jul  8 11:34 libxml2.a

Marked as draft as I didn't test this at runtime yet. I suspect the reader, writer, valid, http and zlib features of libxml2 were required by libgsf instead of librsvg.

@kleisauke
Copy link
Collaborator Author

Seems to work! I tested this with:

$ LD_PRELOAD=$HOME/libvips-8.15.2-linux-x64/lib/libvips-cpp.so.42 npm run test
[...]
  1199 passing (4s)

on sharp's test suite.

@kleisauke kleisauke marked this pull request as ready for review July 8, 2024 16:08
@lovell lovell merged commit ad960df into lovell:main Jul 9, 2024
@lovell
Copy link
Owner

lovell commented Jul 9, 2024

Reduced binary size and reduced attack surface, excellent, thank you Kleis.

@kleisauke kleisauke deleted the xml2-meson branch July 9, 2024 08:48
megantaite pushed a commit to animoto/sharp-libvips that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants