Skip to content

chore: refactor by removing a couple variables #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovell merged 3 commits into from
Jul 19, 2023
Merged

chore: refactor by removing a couple variables #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0118e63
chore: refactor by removing a couple variables
styfle Jul 18, 2023
cb7a8ad
Apply suggestions from code review
styfle Jul 19, 2023
54032fe
Update lib/detect-libc.js
lovell Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions lib/detect-libc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,6 @@ const RE_GLIBC_VERSION = /GLIBC\s(\d+\.\d+)/;
*/
const MUSL = 'musl';

/**
* This string is used to find if the {@link LDD_PATH} is GLIBC
* @type {string}
*/
const GLIBC_ON_LDD = GLIBC.toUpperCase();

/**
* This string is used to find if the {@link LDD_PATH} is musl
* @type {string}
*/
const MUSL_ON_LDD = MUSL.toLowerCase();

const isFileMusl = (f) => f.includes('libc.musl-') || f.includes('ld-musl-');

const familyFromReport = () => {
Expand Down Expand Up @@ -95,10 +83,10 @@ const familyFromCommand = (out) => {
};

const getFamilyFromLddContent = (content) => {
if (content.includes(MUSL_ON_LDD)) {
if (content.includes('musl')) {
return MUSL;
}
if (content.includes(GLIBC_ON_LDD)) {
if (content.includes('GLIBC')) {
return GLIBC;
}
return null;
Expand Down