allow valid auth with empty sid

lovelaze · Oct 8, 2024 · 9115ef0 · 9115ef0
1 parent a2a8e15
commit 9115ef0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/internal/pihole/client.go b/internal/pihole/client.go
@@ -58,14 +58,6 @@ func (a *auth) verify() error {
 		return errors.New("invalid sid found")
 	}
 
-	if a.sid == "" {
-		return errors.New("no sid found")
-	}
-
-	if a.validity <= 0 {
-		return errors.New("expired sid found")
-	}
-
 	return nil
 }
 
@@ -121,6 +113,10 @@ func (client *client) DeleteSession() error {
 		return client.wrapError(err, nil)
 	}
 
+	if client.auth.sid == "" {
+		return nil
+	}
+
 	req, err := http.NewRequest("DELETE", client.ApiPath("auth"), nil)
 	if err != nil {
 		return client.wrapError(err, req)

diff --git a/internal/pihole/client_test.go b/internal/pihole/client_test.go
@@ -132,14 +132,7 @@ func Test_auth_verify(t *testing.T) {
 	assert.Error(t, a.verify())
 
 	a.valid = true
-	assert.Error(t, a.verify())
-
-	a.sid = "sid123"
-	assert.Error(t, a.verify())
-
-	a.validity = 1
 	assert.NoError(t, a.verify())
-
 }
 
 func createClient(container tc.Container) Client {