Skip to content

Update Box2D to 2.4.2 #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update Box2D to 2.4.2 #2217

wants to merge 2 commits into from
+473 −199

Conversation

tpimh
Copy link

@tpimh tpimh commented Sep 3, 2025

Fixes issue #2198

@tpimh tpimh marked this pull request as draft September 3, 2025 10:22
@tpimh
Copy link
Author

tpimh commented Sep 3, 2025

Joint:getType() was returning distance for RopeJoint since Box2D 2.4.1 (because this is what it is now: fc2cf60).

I removed rope value completely, because it became dead code. Maybe it's possible to add some detection logic and return the correct type here:

love/src/modules/physics/box2d/Joint.cpp

Lines 67 to 68 in 5903ad8

case e_distanceJoint:
return JOINT_DISTANCE;

@tpimh
Copy link
Author

tpimh commented Sep 3, 2025

Or maybe it's better to just override getType() like this tpimh@9fa0007?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tpimh