fix(react): add isDevelopment to remove repetitive implementation

love1ace · Jan 27, 2023 · 31be0fb · 31be0fb
1 parent e852516
commit 31be0fb
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 10 deletions.
diff --git a/packages/react/src/AsyncBoundary.tsx b/packages/react/src/AsyncBoundary.tsx
@@ -1,6 +1,7 @@
 import { ComponentProps, ComponentRef, forwardRef } from 'react'
 import { ErrorBoundary } from './ErrorBoundary'
 import { Suspense } from './Suspense'
+import { isDevelopment } from './utils'
 
 type SuspenseProps = ComponentProps<typeof Suspense>
 type ErrorBoundaryProps = ComponentProps<typeof ErrorBoundary>
@@ -17,7 +18,7 @@ const BaseAsyncBoundary = forwardRef<ComponentRef<typeof ErrorBoundary>, Props>(
     </ErrorBoundary>
   )
 )
-if (process.env.NODE_ENV !== 'production') {
+if (isDevelopment) {
   BaseAsyncBoundary.displayName = 'AsyncBoundary'
 }
 const CSROnlyAsyncBoundary = forwardRef<ComponentRef<typeof ErrorBoundary>, Props>(
@@ -27,7 +28,7 @@ const CSROnlyAsyncBoundary = forwardRef<ComponentRef<typeof ErrorBoundary>, Prop
     </ErrorBoundary>
   )
 )
-if (process.env.NODE_ENV !== 'production') {
+if (isDevelopment) {
   CSROnlyAsyncBoundary.displayName = 'AsyncBoundary.CSROnly'
 }
 

diff --git a/packages/react/src/ErrorBoundary.tsx b/packages/react/src/ErrorBoundary.tsx
@@ -12,7 +12,7 @@ import {
   useRef,
 } from 'react'
 import { ErrorBoundaryGroupContext } from './ErrorBoundaryGroup'
-import { isDifferentArray } from './utils'
+import { isDevelopment, isDifferentArray } from './utils'
 
 type Props = PropsWithRef<
   PropsWithChildren<{
@@ -121,6 +121,6 @@ export const ErrorBoundary = forwardRef<{ reset(): void }, ComponentPropsWithout
     return <BaseErrorBoundary {...props} resetKeys={resetKeys} ref={ref} />
   }
 )
-if (process.env.NODE_ENV !== 'production') {
+if (isDevelopment) {
   ErrorBoundary.displayName = 'ErrorBoundary'
 }
diff --git a/packages/react/src/ErrorBoundaryGroup.tsx b/packages/react/src/ErrorBoundaryGroup.tsx
@@ -8,9 +8,10 @@ import {
   useMemo,
 } from 'react'
 import { useIsMounted, useKey } from './hooks'
+import { isDevelopment } from './utils'
 
 export const ErrorBoundaryGroupContext = createContext({ resetKey: 0, reset: () => {} })
-if (process.env.NODE_ENV !== 'production') {
+if (isDevelopment) {
   ErrorBoundaryGroupContext.displayName = 'ErrorBoundaryGroupContext'
 }
 
@@ -85,7 +86,7 @@ export const withErrorBoundaryGroup = <P extends Record<string, unknown> = Recor
     </ErrorBoundaryGroup>
   )
 
-  if (process.env.NODE_ENV !== 'production') {
+  if (isDevelopment) {
     const name = Component.displayName || Component.name || 'Component'
     Wrapped.displayName = `withErrorBoundaryGroup(${name})`
   }

diff --git a/packages/react/src/Suspense.tsx b/packages/react/src/Suspense.tsx
@@ -1,13 +1,14 @@
 import { Suspense as BaseSuspense, SuspenseProps, ComponentProps, ComponentType } from 'react'
 import { useIsMounted } from './hooks'
+import { isDevelopment } from './utils'
 
 type Props = SuspenseProps
 const DefaultSuspense = (props: Props) => <BaseSuspense {...props} />
-if (process.env.NODE_ENV !== 'production') {
+if (isDevelopment) {
   DefaultSuspense.displayName = 'Suspense'
 }
 const CSROnlySuspense = (props: Props) => (useIsMounted() ? <BaseSuspense {...props} /> : <>{props.fallback}</>)
-if (process.env.NODE_ENV !== 'production') {
+if (isDevelopment) {
   CSROnlySuspense.displayName = 'Suspense.CSROnly'
 }
 
@@ -34,7 +35,7 @@ export function withSuspense<Props extends Record<string, unknown> = Record<stri
     </Suspense>
   )
 
-  if (process.env.NODE_ENV !== 'production') {
+  if (isDevelopment) {
     const name = Component.displayName || Component.name || 'Component'
     Wrapped.displayName = `withSuspense(${name})`
   }
@@ -52,7 +53,7 @@ withSuspense.CSROnly = function withSuspenseCSROnly<Props extends Record<string,
     </Suspense.CSROnly>
   )
 
-  if (process.env.NODE_ENV !== 'production') {
+  if (isDevelopment) {
     const name = Component.displayName || Component.name || 'Component'
     Wrapped.displayName = `withSuspense.CSROnly(${name})`
   }

diff --git a/packages/react/src/utils/index.ts b/packages/react/src/utils/index.ts
@@ -1 +1,2 @@
 export { default as isDifferentArray } from './isDifferentArray'
+export { default as isDevelopment } from './isDevelopment'
diff --git a/packages/react/src/utils/isDevelopment.ts b/packages/react/src/utils/isDevelopment.ts
@@ -0,0 +1,3 @@
+const isDevelopment = process.env.NODE_ENV !== 'production'
+
+export default isDevelopment
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		export { default as isDifferentArray } from './isDifferentArray'
		export { default as isDevelopment } from './isDevelopment'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		const isDevelopment = process.env.NODE_ENV !== 'production'

		export default isDevelopment