Fix path used for board download - #34
Closed
iblech wants to merge 3 commits into
Closed
Conversation
Owner
|
Thank you for finding and reporting that @iblech ! I fixed it, and the persistence folder can now be configured with the |
Contributor
Author
|
Awesome, thank you for the proper fix! :-) |
lovasoa
added a commit
that referenced
this pull request
Apr 20, 2026
Collapse duplicated SVG/XML escape helpers into one shared module. The writer now emits numeric entities only (" & ' < >), while the reader still accepts legacy named entities during the transition. This removes duplicated escape/unescape logic and folds decoded text-length handling onto the same entity table. Net diff in touched modules: - server/stored_svg_item_codec.mjs: -75 lines - server/svg_envelope.mjs: -36 lines Validation: - npm run typecheck - node --test test-node/stored_svg_item_codec.test.js test-node/svg_board_store.test.js - npm test - npm run lint - npm run profile Profile after change: - server broadcast throughput: 74.7 ms - load large board: 182.7 ms - persist modifications to large board: 240.0 ms - open large board to peer-visible erase: 695.9 ms (single-sample)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most places in the code reference the
server-datadirectory as__dirname/../server-data. There is a single occurrence where it is referenced directly as./server-data.This pull request harmonizes the usage, so that all references are indirect via
__dirname.(I noticed this when packaging WBO for NixOS. There we need to decouple the
server-datadirectory from the directory where the source files are stored, as the latter directory is readonly in NixOS. In the future, this decoupling could be an option for WBO; meanwhile, a simplesedpatch gets the job done.)