Feature/remove brse arl #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add StringExt dependency Add versions to dependencies
# Conflicts: # Piper/ANSIC.lby # Piper/PiperLogStateChange.c # Piper/Piper_Module_Fub.c # Piper/Piper_handleResponseState.c # Piper/VersionHistory.txt
|
This looks fine, but I dont see where BRSE_ARL is removed and it looks like version number is already used. I think someone made the change in develop already. It seems like this still has other changes that are needed. |
|
I see this as 0.1.8, and develop/main as 0.1.7. |
|
Oh. The VersionHistory.txt previously said 0.1.8, but the library version wasn't actually updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace BRSE_ARL dependency with StringExt and update dependency versions. This should have no effect, since the types in question were identical.