Update dependencies and embed axios-ntlm 1.3.0 into the project #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Are you shure that we should take on the maintenance burden of |
CommanderStorm
added
area:monitor
louislam
commented
Jun 23, 2024
| @@ -79,7 +79,6 @@ | |||
| "@vvo/tzdb": "^6.125.0", | |||
| "args-parser": "~1.3.0", | |||
| "axios": "~0.28.1", | |||
| "axios-ntlm": "1.3.0", | |||
There was a problem hiding this comment.
Not going to maintain, but it was hard coded to 1.3.0 already. Technically no different.
I am doing this because of vulnerabilities in its axios (0.21.x).
Dropping it should prevent more users to upgrade to 2.0.0, so I do not want to. It is also not my plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately,
axios-ntlmcannot be upgraded and1.3.0is depending a older version of axios. Directly embedding it into the project should be the best way for now to deal with it.https://github.com/Catbuttes/axios-ntlm/blob/6292357930bd669d4cbd74948ee68cad8dd21854/package.json#L33-L36