Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect ping log #4322

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix incorrect ping log #4322

merged 1 commit into from
Jan 5, 2024

Conversation

benscobie
Copy link
Contributor

@benscobie benscobie commented Jan 4, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #4321

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@chakflying chakflying added the area:monitor Everything related to monitors label Jan 4, 2024
@louislam louislam added this to the 2.0.0 milestone Jan 4, 2024
@louislam louislam merged commit 25cb787 into louislam:master Jan 5, 2024
17 checks passed
@benscobie benscobie deleted the fix-ping-log branch January 5, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping in Upside down mode logs ping output to console
3 participants