Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditMonitor: add missing config UI for json-query #3751

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Sep 16, 2023

  • I have read and understand the pull request rules.

Description

When editing a json-query monitor some HTTP options like maxredirects are currently not configurable. If I've understood the code correctly, this small change should fix that.

Unfortunately, I don't currently have a suitable environment to test these changes locally (and would prefer not to test them in the docker container on our staging server unless necessary). But the changes are very minimal so figured it was worth opening a PR instead of an issue that would pretty much contain the same information, except these changes can be easily tested and perhaps even merged.

Edit: fixes #3666.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@louislam louislam changed the base branch from master to 1.23.X September 17, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field Request Timeout missing in "HTTP(s) - Json Query" type Monitor.
2 participants