Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show hostname:port for gamedig monitor on Discord notification #3643

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

liorsl
Copy link
Contributor

@liorsl liorsl commented Aug 25, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

When sending Discord notification for a gamedig monitor, show hostname:port (in line with steam and another types) instead of "https://"

PS: I know documentation says to create a draft pr before making a change, but I couldn't open one without making an actual change (if someone has a solution for that I will be glad to learn)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods) (documentation not needed for this one liner imo)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@louislam louislam merged commit c0e273d into louislam:master Aug 26, 2023
14 checks passed
@liorsl liorsl deleted the gamedig-discord-notif branch August 26, 2023 22:52
@stepech stepech mentioned this pull request Sep 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants