Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add debounce to favicon update #3442

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Jul 18, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

favico.js has a queue limit of 100 (source). Too many monitors going down at the same time will cause error:

Uncaught (in promise) Error: Error setting badge. Message: Too many badges requests in queue.
    _readyCb favico.js:337
    badge favico.js:341
    down socket.js:763

This attempts to add a simple debounce to the favicon update.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

@louislam louislam merged commit 09c6798 into louislam:master Aug 1, 2023
14 checks passed
@chakflying chakflying deleted the fix/favicon-debounce branch August 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants