Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker Health Status Support #3169

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

janow25
Copy link
Contributor

@janow25 janow25 commented May 17, 2023

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR adds support for the docker health Status. I thought that would be nice to have. I did not find any similar PR or Issue. It was not that much to change. For a Preview see Screenshots with comments below. (It's my first PR ever, so please don't be hard with me)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Bildschirmfoto 2023-05-17 um 19 03 41

unhealthy is currently marked as PENDING, but could also be marked as DOWN. I'm not sure what's the best in this case.

Bildschirmfoto 2023-05-17 um 19 05 23

This is a Healthy Docker Container

Bildschirmfoto 2023-05-17 um 19 06 07

And this is the Normal Status of a Docker container without a health status.

@janow25 janow25 changed the title added docker health status Added Docker Health Status Support May 17, 2023
@chakflying
Copy link
Collaborator

Since you had to check for Running in both cases maybe keep that in an outer if would be better.

@janow25
Copy link
Contributor Author

janow25 commented May 18, 2023

You are right. I changed that.

@louislam louislam added this to the 1.23.0 milestone May 25, 2023
@louislam louislam merged commit de74efb into louislam:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants