Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invert keyword feature #3040

Merged
merged 3 commits into from
Jul 8, 2023
Merged

Conversation

mlsteele
Copy link
Contributor

@mlsteele mlsteele commented Apr 6, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Add an option for monitors to look for the absence rather the the presence of a keyword. For example to make sure a response does not include the phrase "error".

My motivation is monitoring a the alarm status of a Sensaphone device. Which outputs an xml page that, in the absence of parsing, has many occurrences of the string "Good". And then when there's a problem one of the occurrences changes to "Bad". "Upside down" mode is not suited to the task because the monitor should alert if the page is unreachable.

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

image

@mlsteele mlsteele marked this pull request as ready for review April 7, 2023 02:58
@mlsteele
Copy link
Contributor Author

@louislam wdyt?
I'd like to get back to running main instead of a fork but need this feature.

@louislam louislam added this to the 1.23.0 milestone Jun 24, 2023
@louislam
Copy link
Owner

louislam commented Jul 8, 2023

@louislam wdyt? I'd like to get back to running main instead of a fork but need this feature.

Thanks for the pr. Tested, it is working.

It may be a bit wired when both Upside Down mode + Invert Keyword are checked, but never mind, we could think about this later.

@louislam louislam merged commit ed6b4e5 into louislam:master Jul 8, 2023
14 checks passed
@louislam louislam temporarily deployed to github-pages July 8, 2023 08:33 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants