-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast notification timeout settings #2555
Toast notification timeout settings #2555
Conversation
That is great. It will be accepted. The timeout setting could be under |
Since this is only used in the browser, you can keep it simple by storing it in
I guess you would similarly sends this setting afterLogin, and the frontend receive it and store it somewhere. |
|
@@ -163,7 +168,10 @@ export default { | |||
}, | |||
|
|||
methods: { | |||
|
|||
deleteNotifications() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add jsdoc for the methods you have added
|
There are 68 files changed. I think something went wrong. |
@louislam @BercziSandor |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Currently there is no time limit on error messages (20s for warnings); this behavior can be very annoying: the user has to close many notifications before being able to use the interface.
To remedy this, the following should/could be changed:
Fixes #2116
Comments
vue-toastification
. (If there are no messages, the button should be hidden)Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.