Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float ping value #3345

Closed
1 task done
Potat0000 opened this issue Jul 3, 2023 · 5 comments
Closed
1 task done

Support float ping value #3345

Potat0000 opened this issue Jul 3, 2023 · 5 comments
Labels
feature-request Request for new features to be added

Comments

@Potat0000
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

In #3343 and #3320 , I said that I'm using the ping field to record the latency to the gateway. Obviously a float type data is very necessary in this case because all the latency data is between 1ms and 2ms. This feature may have been implemented by mistake since in version 1.21 and earlier, it could record ping values with float type and the graph below can also display the float type graph very well.

✔️ Solution

Supporting float ping value for push type and even for other type (for Response field).

❓ Alternatives

No response

📝 Additional Context

No response

@Potat0000 Potat0000 added the feature-request Request for new features to be added label Jul 3, 2023
@Potat0000 Potat0000 changed the title Supporting float ping value Support float ping value Jul 3, 2023
@CommanderStorm
Copy link
Collaborator

Why is the difference between 1..2ms important to you?
At such latency, are other metrics (99p/...) not more import for you?

@Nuklon
Copy link

Nuklon commented Aug 17, 2023

The value for the ping is an integer globally ⇒ changing this in one corner would change this for every monitor => Nelsons assessment is correct, this is a duplicate

Why do you need to differentiate between 10.3 and 10ms?

I monitor sites on the same server as UK is running on, so it's not 10ms but 1-2ms. This is not useful to differentiate and creates a very jagged graph.

@CommanderStorm
Copy link
Collaborator

@Potat0000 #3987 was merged and relased in v1.23.4.
This issue was apparently forgotten to close, could you close it?

@Nuklon
Copy link

Nuklon commented Nov 30, 2023

@Potat0000 #3987 was merged and relased in v1.23.4. This issue was apparently forgotten to close, could you close it?

This is not fixed, I'm using 1.23.7 and HTTP is still rounded to int.

@Potat0000
Copy link
Author

This is not fixed, I'm using 1.23.7 and HTTP is still rounded to int.

Thank you to all of you who are still following this issue.

It can be confirmed that in 1.23.7 push type can store float value again. Since my original request is to support float ping value for push type, I think this issue could close as completed. You can open another issue to ask for float values for other types like HTTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

3 participants