Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push type minitor can't deal with ping value with decimals in 1.22.0 #3320

Closed
2 tasks done
Potat0000 opened this issue Jun 27, 2023 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@Potat0000
Copy link

Potat0000 commented Jun 27, 2023

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

Push type minitor can't deal with ping value with decimals.

The issue didn't exist in 1.21.3 . It first appear in 1.22.0

👟 Reproduction steps

  1. Create a monitor with push type.
  2. Call https://domain.tld/api/push/xxxxxxxx?status=up&msg=OK&ping=12.345
  3. Shows "12" as ping value.

👀 Expected behavior

Shows "12.345" as ping value.

😓 Actual Behavior

Shows "12" as ping value.

🐻 Uptime-Kuma Version

1.22.0

💻 Operating System and Arch

Debian 12

🌐 Browser

Edge 114.0.1823.58

🐋 Docker Version

24.0.2

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@Potat0000 Potat0000 added the bug Something isn't working label Jun 27, 2023
@Potat0000 Potat0000 changed the title Push type minitor can't deal with ping value with decimals Push type minitor can't deal with ping value with decimals in 1.22.0 Jun 27, 2023
@CommanderStorm
Copy link
Collaborator

@Potat0000
I would suggest we continue this issue in #3343, as this is a more generic issue.
Could you close this issue?

@CommanderStorm
Copy link
Collaborator

See #3343 (comment)
=> This is not a bug, but rather intended behaviour.

Out of curiosity: Why would you need sub-1ms ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants