Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse MicroProfile Health monitor #2501

Open
1 task done
skaempfe opened this issue Dec 29, 2022 · 0 comments
Open
1 task done

Eclipse MicroProfile Health monitor #2501

skaempfe opened this issue Dec 29, 2022 · 0 comments
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:new proposing to add a new monitor

Comments

@skaempfe
Copy link
Contributor

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Monitor

🔖 Feature description

Adding "MicroProfile Health Check" as a new "specific monitor type".
The HTTP Request responds with a JSON, representing an application server with deployed applications. The response can be evaluated to get a detailed Overview of possible problems and their root cause.

✔️ Solution

I have implemented the feature and will provide a pull request shortly for further inspection.

❓ Alternatives

I have considered using the "HTTP keyword" monitor but in case of a "DOWN" not enough information can be extracted so extra steps are necessary to obtain the real cause. I want to shortcut these extra steps to improve response time.

📝 Additional Context

from Eclipse MicroProfile Health:

Motivation

Health checks are used to probe the state of a computing node from another machine (i.e. kubernetes service controller) with the primary target being cloud infrastructure environments where automated processes maintain the state of computing nodes.

In this scenario, health checks are used to determine if a computing node needs to be discarded (terminated, shutdown) and eventually replaced by another (healthy) instance.

It’s not intended (although could be used) as a monitoring solution for human operators.

Eclipse MicroProfile Health - Protocol and Wireformat

@skaempfe skaempfe added the feature-request Request for new features to be added label Dec 29, 2022
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Dec 29, 2022
- adding new monitor type "mp-health" in Selectbox with name "MicroProfile Health Check" as a "Specific Monitor Type"
- adding "mp-health" for configuration options URL, TLS-Settings, max Redirects and Proxy.
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Dec 29, 2022
- added a new method `analyzeHealthcheckResponse` with a detailed implementation of the checks so the main method `start` does not get too complicated.
- added the new monitor type `mp-health` on two positions within `start` to ensure its correct execution.
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Dec 29, 2022
- ensure that the response content type is also recognized when the server provides additional charset information (`application/json;charset=UTF-8`)
@louislam louislam added this to the 1.20.0 milestone Jan 1, 2023
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Jan 2, 2023
- had to further weaken the JSON check to also accept derivates like `application/vnd.spring-boot.actuator.v3+json`
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Jan 2, 2023
- enable HTTP Method, Headers and Body for monitor type `mp-health` when editing the entry.
- enable `Toggle Clickable Link` for monitor type `mp-health` when editing a monitor entry on the status page.
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Jan 30, 2023
- enable clickable URL on Dashboard Details if monitor is of type `mp-health`
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Feb 13, 2023
skaempfe added a commit to skaempfe/uptime-kuma that referenced this issue Feb 13, 2023
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Dec 6, 2023
@CommanderStorm CommanderStorm changed the title new monitor type: MicroProfile Health Check Eclipse MicroProfile Health monitor Dec 6, 2023
@chakflying chakflying modified the milestones: 1.20.0, Pending Dec 10, 2023
@CommanderStorm CommanderStorm removed this from the Pending milestone Feb 17, 2024
@CommanderStorm CommanderStorm added the type:new proposing to add a new monitor label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants