Fix Async child process output issue (#4231)

louislam · Dec 13, 2023 · 8151ac0 · 8151ac0
1 parent 4185ec2
commit 8151ac0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/server/monitor-types/tailscale-ping.js b/server/monitor-types/tailscale-ping.js
@@ -39,7 +39,8 @@ class TailscalePing extends MonitorType {
     async runTailscalePing(hostname, interval) {
         let timeout = interval * 1000 * 0.8;
         let res = await childProcessAsync.spawn("tailscale", [ "ping", "--c", "1", hostname ], {
-            timeout: timeout
+            timeout: timeout,
+            encoding: "utf8",
         });
         if (res.stderr && res.stderr.toString()) {
             throw new Error(`Error in output: ${res.stderr.toString()}`);

diff --git a/server/notification-providers/apprise.js b/server/notification-providers/apprise.js
@@ -11,7 +11,9 @@ class Apprise extends NotificationProvider {
             args.push("-t");
             args.push(notification.title);
         }
-        const s = await childProcessAsync.spawn("apprise", args);
+        const s = await childProcessAsync.spawn("apprise", args, {
+            encoding: "utf8",
+        });
 
         const output = (s.stdout) ? s.stdout.toString() : "ERROR: maybe apprise not found";