Skip to content

Fix generation of railway tunnels#1203

Open
floze-the-genius wants to merge 2 commits into
louis-e:mainfrom
floze-the-genius:fix/994-rail-tunnels
Open

Fix generation of railway tunnels#1203
floze-the-genius wants to merge 2 commits into
louis-e:mainfrom
floze-the-genius:fix/994-rail-tunnels

Conversation

@floze-the-genius

Copy link
Copy Markdown

Summary

  • route railway=* ways tagged tunnel=yes through the existing two-phase underground railway generator instead of dropping them
  • generalize the subway-only tunnel bookkeeping names to cover ordinary train tunnels
  • add regression coverage that verifies a heavy-rail tunnel keeps its rail, carves its interior, preserves its walls, and does not render at grade

Fixes #994

Testing

  • cargo fmt --all -- --check
  • cargo test --all-targets --all-features (359 passed, 6 ignored)
  • cargo clippy --all-targets --all-features -- -D warnings

@floze-the-genius
floze-the-genius marked this pull request as ready for review July 19, 2026 10:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7eeec1dd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/element_processing/railways.rs Outdated
Comment thread src/element_processing/railways.rs Outdated

Copy link
Copy Markdown
Author

The benchmark itself completed successfully: generation time was 19s versus the 18s baseline, and peak memory was 1181 MB versus 1160 MB; both are classified as unchanged by the workflow. The check is red only because the fork-scoped GITHUB_TOKEN could not create the benchmark report comment (Resource not accessible by integration), so I am recording the result here manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Railway Generation

1 participant