Fix Binary Search

louietyj · Oct 10, 2017 · bacabb4 · bacabb4
1 parent de31ca8
commit bacabb4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/algorithms/__tests__/binarySearch.test.js b/lib/algorithms/__tests__/binarySearch.test.js
@@ -5,15 +5,15 @@ describe('binarySearch', () => {
     expect(binarySearch([], 1)).toBe(-1);
   });
 
-  test('one or two', () => {
+  test('one or two elements', () => {
     expect(binarySearch([1], 1)).toBe(0);
     expect(binarySearch([1], 2)).toBe(-1);
     expect(binarySearch([1, 4], 1)).toBe(0);
     expect(binarySearch([1, 4], 4)).toBe(1);
     expect(binarySearch([1, 4], 5)).toBe(-1);
   });
 
-  test('normal', () => {
+  test('more than two elements', () => {
     expect(binarySearch([1, 2, 3, 10, 11, 20], 1)).toBe(0);
     expect(binarySearch([1, 2, 3, 10, 11, 20], 2)).toBe(1);
     expect(binarySearch([1, 2, 3, 10, 11, 20], 3)).toBe(2);

diff --git a/lib/algorithms/binarySearch.js b/lib/algorithms/binarySearch.js
@@ -1,4 +1,5 @@
 function binarySearch(arr, target) {
+  // TODO - Decide which index to return if there are duplicate values in array.
   let left = 0;
   let right = arr.length - 1;
   while (left <= right) {