-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring and improvements #52
base: master
Are you sure you want to change the base?
Conversation
…US) and Dutch (nl-NL) locale. The advantages of this format are: - 1 object with all the labels. This object is in valid JSON format (quotes around propertynames). Because of this the object can be used directly in JSON resource files. - Easier to read.
The translation of Clear for the filter was hard coded to "Cancelar" in the demo. I made this fix for English and Swedish in commit 7005ea2. This is for the rest of the translations. Also removing demo\swe.html which was added by mistake.
will likely broke -> will likely brake Svenska -> Swedish
This translation applicable for all Arabic cultures "ar"
Wrong 'GRID GROUP PANEL MESSAGES' translation.
Panamanian Spanish file for KendoUI localization.
new messages were added; misprints in localization were corrected; some of messages localizations were changed
Globalization up to v2013.3.1119
This reverts commit ccb535d.
- Converted all language files to .json - Added gulpfile.js, which builds both the .js files and the demo files (see README.md). - Added bower.json, so the package can be download via Bower (see README.md). - Updated README.md.
- Converted all language files to .json - Added gulpfile.js, which builds both the .js files and the demo files (see README.md). - Added bower.json, so the package can be download via Bower (see README.md). - Updated README.md.
Nice work. Since I've got no idea what Gulp is, I'll have to consider if it will add any dependency to use the project. Currently all you have to do is to drop the needed JS, and I would like for this project to remain as simple as possible. So I'll weight the pros and cons of a JSON approach (I didn't actually looked at the changes to see how it works, I may not be making sense :-) ) |
I will explain a bit more about my changes, and also why I added Gulp and what it does. The current approach of this project is nice when your application just uses one language. You just drop in the appropriate language file and you're done.
First of all, I transformed all the Javascript files to plain JSON files, such as this one. Since, we still need the Javascript files, which load the labels of one particular language. The only way to keep this maintainable is to automate it. This is where Gulp comes in. Gulp is a node module aimed at automating development tasks like this. You use Gulp by writing a Something which I still have to do is write a script (maybe as jQuery plugin) which can dynamically load and switch languages, by loading the JSON files (using jQuery). |
Mark, |
That's ok. I know the feeling ;). |
@loudenvier I finally got some time to convert all the language files to .json. This pull requests contains the following (big) changes:
bower.json
file, so the repository can be distributed via Bower.