Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hubert): Make dialogs full-height on iOS (use 100dvh) #201

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ptitmouton
Copy link
Contributor

Fixes #127

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (dbd1fb1) to head (29d0544).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   60.36%   63.61%   +3.25%     
==========================================
  Files         264      343      +79     
  Lines        4748     5513     +765     
  Branches      624      722      +98     
==========================================
+ Hits         2866     3507     +641     
- Misses       1706     1791      +85     
- Partials      176      215      +39     
Flag Coverage Δ
hubert 83.79% <ø> (∅)
storybook-addon-theme ?
webapp 60.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptitmouton ptitmouton merged commit 240a5fa into main Mar 26, 2024
16 checks passed
@ptitmouton ptitmouton deleted the bugfix/full-height-drawer branch March 26, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant