remove query-string dependancy, npm audit #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the delay, I wanted to test properly before merging, this works perfectly thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Here's my first take: make a fake URL and then get path and searchParams from it. I don't really like the fake url in the long run but I think it's the best solution right now
I was curious if the path that gets passed around could be replaced by a full URL but the
toprop inLinkis the origin of the parameter. So for that to work, the full URL including thetowould have to be known by theLinkor it would have to be added somewhere along the way (afterTriggerPageLoadand beforebundle.Init)