Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect use of logger middleware in docs #1497

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix incorrect use of logger middleware in docs #1497

merged 1 commit into from
Apr 14, 2023

Conversation

mattbrictson
Copy link
Contributor

f.request :logger as originally suggested in the docs does not work.

:logger is not registered on Faraday::Request (Faraday::Error)

The correct usage is f.response :logger

@mattbrictson
Fix incorrect use of logger middleware in docs
2548fee 
`f.request :logger` as originally suggested in the docs does not work.

```
:logger is not registered on Faraday::Request (Faraday::Error)
```

The correct usage is `f.response :logger`
@olleolleolle
Copy link
Member

Thanks, @mattbrictson!

iMacTia
iMacTia approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @mattbrictson

@iMacTia iMacTia merged commit 75dfbd6 into lostisland:main Apr 14, 2023
@mattbrictson mattbrictson deleted the patch-1 branch April 14, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattbrictson @olleolleolle @iMacTia