Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProxyOptions should treat empty string as nil #1493

Merged
merged 5 commits into from
May 23, 2023
Merged

ProxyOptions should treat empty string as nil #1493

merged 5 commits into from
May 23, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 22, 2023 •
edited
Loading

Description

After this PR, ProxyOptions treats an empty String '' as nil, so adapters can ignore the useless ProxyOption.
Fixes #1492

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • N/A Documentation

@exoego exoego marked this pull request as ready for review February 23, 2023 10:22
iMacTia
iMacTia approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @exoego and sorry if it took me so long to review 🙇

@iMacTia iMacTia merged commit 98947e6 into lostisland:main May 23, 2023
@exoego exoego deleted the empty-string-proxy branch May 23, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faraday::ConnectionFailed if proxy: "" is passed on Ruby 3.2.1
2 participants
@exoego @iMacTia