Skip to content

fix: richtext toDelta cache err when importing snapshot #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

zxch3n
Copy link
Member

@zxch3n zxch3n commented Apr 8, 2025

No description provided.

@zxch3n zxch3n requested a review from Copilot April 8, 2025 16:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

crates/loro-wasm/tests/richtext.test.ts:372

  • [nitpick] The initial expectation of an empty delta might be redundant since the subscription callback later verifies the updated delta. Consider removing or adding a comment clarifying its necessity in ensuring test clarity.
expect(textB.toDelta()).toStrictEqual([]);

@zxch3n zxch3n merged commit 998a737 into main Apr 9, 2025
1 check passed
@zxch3n zxch3n deleted the fix-richtext-todelta-cache branch April 9, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant