Skip to content

feat: add functionality to delete and hide empty root containers #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

zxch3n
Copy link
Member

@zxch3n zxch3n commented Apr 8, 2025

Resolve #682

  • Implemented delete_root_container method to remove content from root containers and hide them from document snapshots.
  • Added set_hide_empty_root_containers method to control visibility of empty root containers.
  • Updated tests to verify the new functionality for deleting and hiding root containers.
  • Enhanced LoroValue with is_empty_collection method to check for empty collections.

zxch3n added 3 commits April 8, 2025 16:03
- Implemented `delete_root_container` method to remove content from root containers and hide them from document snapshots.
- Added `set_hide_empty_root_containers` method to control visibility of empty root containers.
- Updated tests to verify the new functionality for deleting and hiding root containers.
- Enhanced `LoroValue` with `is_empty_collection` method to check for empty collections.
@zxch3n zxch3n requested review from Copilot and Leeeon233 and removed request for Copilot April 8, 2025 08:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

zxch3n and others added 2 commits April 8, 2025 16:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zxch3n zxch3n merged commit bf94a03 into main Apr 8, 2025
1 check passed
@zxch3n zxch3n deleted the feat-delete-root-container branch April 8, 2025 10:28
@github-actions github-actions bot mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to hide root containers when they are empty
1 participant