Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickAction was adapted to HD-screens. #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mksmbrtsh
Copy link

Hi, i fixs bug in shown QuickAction at larges screens.

QuickAction correctly shown at small screens, her width is width of screen.
And QuickActtion correctly shown at large screen, and her width value is MAX_WIDTH_POPUP_WINDOWS constant. Arrow shown is correctly, too.

  • Add constant MAX_WIDTH_POPUP_WINDOWS;
  • Set min SDK version(API 7, as before) and target SDK version(API 15).

@evanrich
Copy link

I tried using your changes, and while the arrow shows up, it seems to cut my action bar in half. will play around with it some to see if i can fix it

Edit: Fixed by changing your PopupWindows.java to say the following:
public static final int MAX_WIDTH_POPUP_WINDOWS = 865;

This causes my actionbar with 3 items to render correctly on an HTC one with 1920x1080 screen. 450 was too small.

Edit: this still doesn't work as when I run it on the emulator with an 800x480 screen it shifts left. anyone know the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants