Skip to content

Commit

Permalink
Missing setter: Unhandled exception handler should be removed from th…
Browse files Browse the repository at this point in the history
…e Topshelf Topshelf#476
  • Loading branch information
jonreis authored and phatboyg committed Jan 12, 2019
1 parent e92bff1 commit ea2f383
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,8 @@ class MyHostConfigurator : HostConfigurator

public UnhandledExceptionPolicyCode UnhandledExceptionPolicy => throw new NotImplementedException();

UnhandledExceptionPolicyCode HostConfigurator.UnhandledExceptionPolicy { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }

public void AddCommandLineDefinition(string name, Action<string> callback)
{
throw new NotImplementedException();
Expand Down
10 changes: 5 additions & 5 deletions src/Topshelf/Configuration/HostConfigurators/HostConfigurator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ public interface HostConfigurator
/// <param name="callback">The action to run when an exception occurs.</param>
void OnException(Action<Exception> callback);

/// <summary>
/// The policy that will be used when Topself detects an UnhandledException in the
/// application. The default policy is to log an error and to stop the service.
/// </summary>
UnhandledExceptionPolicyCode UnhandledExceptionPolicy { get; }
/// <summary>
/// The policy that will be used when Topself detects an UnhandledException in the
/// application. The default policy is to log an error and to stop the service.
/// </summary>
UnhandledExceptionPolicyCode UnhandledExceptionPolicy { get; set; }
}
}

0 comments on commit ea2f383

Please sign in to comment.