Skip to content

Add America Rising - A Tale of the Enclave#693

Merged
pStyl3 merged 1 commit into
loot:v0.21from
ddbb07:amri-1
Apr 8, 2025
Merged

Add America Rising - A Tale of the Enclave#693
pStyl3 merged 1 commit into
loot:v0.21from
ddbb07:amri-1

Conversation

@ddbb07
Copy link
Copy Markdown
Contributor

@ddbb07 ddbb07 commented Mar 29, 2025

* Add main plugin
- America Rising - A Tale of the Enclave.esp

* Add location to main plugin
- https://www.nexusmods.com/fallout4/mods/23923/

* Add message to main plugin
- &patch3rdParty_REFPH

* Add cleaning data to main plugin
- Version: 1.1.2

Based on #692, will rebase this when needed.

Copy link
Copy Markdown
Member

@pStyl3 pStyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR.

Comment thread masterlist.yaml
Comment on lines +3875 to +3877
clean:
- crc: 0x75DA3F6A
util: 'FO4Edit v4.1.5f'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't add clean data, if the plugin is dirty, so this can be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware that it's only applicable to that version of xEdit, and it's therefore hard to maintain. But i would like to keep it since it still adds usable information.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's one reason why we usually refrain from adding the clean data, if the plugin is dirty to begin with. Another one is to simply keep the size of the masterlists as small as possible and to not add information, where the added value isn't clear. Unless I'm missing something here?

Don't get me wrong, I don't think this part here would be a big deal. But having said that, right now I don't see a good reason, why we should start to add both dirty and clean data for a singular plugin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally use the clean checksums both to verify file integrity and to confirm that the specific file has been properly cleaned.

If I only check whether a file doesn't match the dirty-sum, that could mean multiple things: either that the plugin genuinely is clean, the masterlist entry is outdated, or an unintentional change has happened to the file. Whereas the clean-sum unambiguously verifies that the file is both properly cleaned and retains its integrity.

But I understand if you still don't want it in the masterlist, since it is a pretty limited use case.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your reasoning, though I still prefer our existing mode of operation to be honest. As such, please remove the clean info from this PR, then there's no problem merging it.

* Add main plugin
- America Rising - A Tale of the Enclave.esp

* Add location to main plugin
- https://www.nexusmods.com/fallout4/mods/23923/

* Add message to main plugin
- &patch3rdParty_REFPH

* Add cleaning data to main plugin
- Version: 1.1.2
@pStyl3 pStyl3 merged commit 82ecf8e into loot:v0.21 Apr 8, 2025
@ddbb07 ddbb07 deleted the amri-1 branch May 30, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants