This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Fixes loopline-systems/closeio-api-wrapper#21 - Give ResourceNotFoundException when resource is not found #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce is not found
mickadoo
reviewed
Nov 3, 2017
|
|
||
| if ($response->hasErrors()) { | ||
| throw new BadApiRequestException($response->getErrors()); | ||
| if ($response->getReturnCode() == 404) { |
Collaborator
There was a problem hiding this comment.
Can you check if the return code is a string or an int? If it's an int might be nicer to have strict check here.
Contributor
Author
There was a problem hiding this comment.
Your wish is my command
mickadoo
approved these changes
Nov 3, 2017
Collaborator
mickadoo
left a comment
mickadoo
left a comment
There was a problem hiding this comment.
Minor suggestion for type check, but otherwise seems fine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21