This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Fixes loopline-systems/closeio-api-wrapper#28 . Support wrong telephone format errors #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@danbarker thanks for all these PRs. For this one do you think you could beef up the description a little more with a sample of the output before and after - just to make it clearer the situation this will fix. |
Contributor
Author
|
I've just added more detail in the original issue description: #28 |
mickadoo
approved these changes
Nov 6, 2017
Collaborator
mickadoo
left a comment
mickadoo
left a comment
There was a problem hiding this comment.
Thanks for updating the description, looks good to me 👍
Contributor
|
Thanks for contributing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28