Reconnection capability and fail fast TCP connection #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxekman
reviewed
Jul 12, 2017
| conn.SetKeepAlivePeriod(1*time.Second) | ||
| conn.SetNoDelay(true) | ||
| conn.SetWriteDeadline(tcp_timeout) | ||
| a.conn = conn |
There was a problem hiding this comment.
You probably don't have to set the conn again here, right?
| @@ -155,16 +158,38 @@ func (a *LogstashAdapter) Stream(logstream chan *router.Message) { | |||
| js = append(js, byte('\n')) | |||
|
|
|||
| for { | |||
| _, err := a.conn.Write(js) | |||
| if a.route.AdapterTransport(a.route.Adapter) == "tcp" && os.Getenv("TCP_TIMEOUT") != "" { | |||
There was a problem hiding this comment.
What are the impacts of checking this for every Write?
|
Thanks for tackling the issues! |
|
@rasjoh It would be great if the questions could be answered. (Also needs a rebase after merging the last PR) |
|
Closing due to lack of response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve connection robustness (reconnects)
Added TCP_TIMEOUT parameter to be able to fail the connection fast in case of an unplanned outage of the connection recipient