Add option to provide pubsub configuration for topic #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides the ability to configure the creation of the GCP PubSub topic. Specifically I wanted to be able to specify message retention. This paves the way for replaying messages to enable projections to resync.
Affected Components
Related Issues
Nothing specific but begins to address projection errors. Only for GCP though.
Solution and Design
The pubsub client also has a CreateTopicWithConfig function which takes an additional argument of a
TopicConfig
struct. By adding an additional function to the gcp eventbus package (WithTopicOptions
, copypasta ofWithPubSubOptions
but updates different struct property) we can supply aTopicConfig
struct as an option toNewEventBus()
.Steps to test and verify
TestEventBusWithConfigIntegration
test in eventbus_test.go.