Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding kafka eventbus topic name #380

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

JohnRoesler
Copy link
Contributor

Description

I have a specific topic naming pattern I would like to follow for my events on the event bus. this adds an option to override the default set by the event bus

Affected Components

  • Event Bus, Event Store etc

Related Issues

#123

Solution and Design

Short description of the solution.

Steps to test and verify

  1. ...

@coveralls
Copy link

coveralls commented Feb 14, 2022

Coverage Status

Coverage increased (+0.03%) to 68.824% when pulling e3b4400 on JohnRoesler:topic into 9c37770 on looplab:main.

Copy link
Member

@maxekman maxekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you please remove the Stretchify dependency that you added in the last PR. It slipped my review. In general I don’t want that kind of dependency on an external library for such a small addition. Thanks!

Copy link
Member

@maxekman maxekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@maxekman maxekman merged commit 1a72481 into looplab:main Feb 15, 2022
@maxekman
Copy link
Member

Great addition! Thanks 🙏

@JohnRoesler JohnRoesler deleted the topic branch February 15, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants