Fix / Return error in projector for removed models #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxekman
force-pushed
the
362-error-on-deleted-projection
branch
from
2444832
to
f6db37c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return
projector.ErrModelRemovedin case the model was removed when projecting. This check only works if regular versioning is used as the removed status can't be discerned from a not-created entity that would begin on for example version 2.Affected Components
Related Issues
Fixes #362
Solution and Design
Works by checking that the event is v1 if the model is v0, which means that the model did not exist in the store.
Steps to test and verify