Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

109 / Add persistance to command scheduler #351

Merged

Conversation

maxekman
Copy link
Member

Description

Adds persistence to the command scheduler middleware using a Repo. All persisted command are loaded and scheduled on Start() and unloaded on Stop(). Commands are persisted when they submitted to HandleCommand() and removed after they have been handled on the schedule.

Affected Components

  • Command Scheduler Middleware

Related Issues

#109

Solution and Design

Steps to test and verify

@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch from e3c5562 to 60b51a8 Compare November 1, 2021 14:13
@coveralls
Copy link

coveralls commented Nov 1, 2021

Coverage Status

Coverage increased (+0.6%) to 69.054% when pulling c1fd089 on maxekman:feature-109/persistent-scheduled-commands into c4089ff on looplab:main.

@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch from 60b51a8 to dc01277 Compare November 1, 2021 15:09
@maxekman maxekman changed the title WIP: Isuse-109 / Add persistance to command scheduler Isuse-109 / Add persistance to command scheduler Nov 1, 2021
@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch 5 times, most recently from 20cfafe to 7e851ce Compare November 1, 2021 15:30
@maxekman maxekman changed the title Isuse-109 / Add persistance to command scheduler 109 / Add persistance to command scheduler Nov 8, 2021
@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch 2 times, most recently from 609ad4d to 961111f Compare November 9, 2021 09:08
@haderach75
Copy link

Looks great, done scenario testing and it works according to our requirements.

@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch 2 times, most recently from 2a13b17 to 8505e01 Compare November 22, 2021 12:48
@maxekman
Copy link
Member Author

@haderach75 I have changed the API slightly by adding a separate Load() method instead of being part of Start(). Can you please do a quick re-review?

@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch from 8505e01 to a5a08e3 Compare November 22, 2021 14:40
@maxekman maxekman force-pushed the feature-109/persistent-scheduled-commands branch from a5a08e3 to c1fd089 Compare November 22, 2021 14:49
@maxekman maxekman merged commit bc7e608 into looplab:main Nov 26, 2021
@maxekman maxekman deleted the feature-109/persistent-scheduled-commands branch November 26, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants