-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
109 / Add persistance to command scheduler #351
Merged
maxekman
merged 9 commits into
looplab:main
from
maxekman:feature-109/persistent-scheduled-commands
Nov 26, 2021
Merged
109 / Add persistance to command scheduler #351
maxekman
merged 9 commits into
looplab:main
from
maxekman:feature-109/persistent-scheduled-commands
Nov 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxekman
commented
Oct 26, 2021
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
from
November 1, 2021 14:13
e3c5562
to
60b51a8
Compare
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
from
November 1, 2021 15:09
60b51a8
to
dc01277
Compare
maxekman
changed the title
WIP: Isuse-109 / Add persistance to command scheduler
Isuse-109 / Add persistance to command scheduler
Nov 1, 2021
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
5 times, most recently
from
November 1, 2021 15:30
20cfafe
to
7e851ce
Compare
maxekman
changed the title
Isuse-109 / Add persistance to command scheduler
109 / Add persistance to command scheduler
Nov 8, 2021
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
2 times, most recently
from
November 9, 2021 09:08
609ad4d
to
961111f
Compare
qzio
reviewed
Nov 18, 2021
qzio
reviewed
Nov 18, 2021
qzio
reviewed
Nov 18, 2021
Looks great, done scenario testing and it works according to our requirements. |
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
2 times, most recently
from
November 22, 2021 12:48
2a13b17
to
8505e01
Compare
@haderach75 I have changed the API slightly by adding a separate |
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
from
November 22, 2021 14:40
8505e01
to
a5a08e3
Compare
maxekman
force-pushed
the
feature-109/persistent-scheduled-commands
branch
from
November 22, 2021 14:49
a5a08e3
to
c1fd089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds persistence to the command scheduler middleware using a Repo. All persisted command are loaded and scheduled on
Start()
and unloaded onStop()
. Commands are persisted when they submitted toHandleCommand()
and removed after they have been handled on the schedule.Affected Components
Related Issues
#109
Solution and Design
Steps to test and verify