fix: Enable parallel testing where possible

looplab · Oct 22, 2021 · 7917d26 · 7917d26
1 parent 139df9a
commit 7917d26
Show file tree

Hide file tree

Showing 35 changed files with 173 additions and 6 deletions.
diff --git a/aggregate_test.go b/aggregate_test.go
@@ -23,6 +23,8 @@ import (
 )
 
 func TestCreateAggregate(t *testing.T) {
+	t.Parallel()
+
 	id := uuid.New()
 	_, err := CreateAggregate(TestAggregateRegisterType, id)
 	if !errors.Is(err, ErrAggregateNotRegistered) {
@@ -47,6 +49,8 @@ func TestCreateAggregate(t *testing.T) {
 }
 
 func TestRegisterAggregateEmptyName(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: attempt to register empty aggregate type" {
 			t.Error("there should have been a panic:", r)
@@ -58,6 +62,8 @@ func TestRegisterAggregateEmptyName(t *testing.T) {
 }
 
 func TestRegisterAggregateNil(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: created aggregate is nil" {
 			t.Error("there should have been a panic:", r)
@@ -67,6 +73,8 @@ func TestRegisterAggregateNil(t *testing.T) {
 }
 
 func TestRegisterAggregateTwice(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: registering duplicate types for \"TestAggregateRegisterTwice\"" {
 			t.Error("there should have been a panic:", r)

diff --git a/aggregatestore/events/aggregatebase_test.go b/aggregatestore/events/aggregatebase_test.go
@@ -25,6 +25,8 @@ import (
 )
 
 func TestNewAggregateBase(t *testing.T) {
+	t.Parallel()
+
 	id := uuid.New()
 	agg := NewAggregateBase(TestAggregateType, id)
 	if agg == nil {
@@ -42,6 +44,8 @@ func TestNewAggregateBase(t *testing.T) {
 }
 
 func TestAggregateVersion(t *testing.T) {
+	t.Parallel()
+
 	agg := NewAggregateBase(TestAggregateType, uuid.New())
 	if agg.AggregateVersion() != 0 {
 		t.Error("the version should be 0:", agg.AggregateVersion())
@@ -54,6 +58,8 @@ func TestAggregateVersion(t *testing.T) {
 }
 
 func TestAggregateEvents(t *testing.T) {
+	t.Parallel()
+
 	id := uuid.New()
 	agg := NewTestAggregate(id)
 	timestamp := time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC)

diff --git a/aggregatestore/events/aggregatestore_test.go b/aggregatestore/events/aggregatestore_test.go
@@ -27,6 +27,8 @@ import (
 )
 
 func TestNewAggregateStore(t *testing.T) {
+	t.Parallel()
+
 	eventStore := &mocks.EventStore{
 		Events: make([]eh.Event, 0),
 	}
@@ -49,6 +51,8 @@ func TestNewAggregateStore(t *testing.T) {
 }
 
 func TestAggregateStore_LoadNoEvents(t *testing.T) {
+	t.Parallel()
+
 	store, _ := createStore(t)
 
 	ctx := context.Background()
@@ -71,6 +75,8 @@ func TestAggregateStore_LoadNoEvents(t *testing.T) {
 }
 
 func TestAggregateStore_LoadEvents(t *testing.T) {
+	t.Parallel()
+
 	store, eventStore := createStore(t)
 
 	ctx := context.Background()
@@ -133,6 +139,8 @@ func TestAggregateStore_LoadEvents(t *testing.T) {
 }
 
 func TestAggregateStore_LoadEvents_MismatchedEventType(t *testing.T) {
+	t.Parallel()
+
 	store, eventStore := createStore(t)
 
 	ctx := context.Background()
@@ -162,6 +170,8 @@ func TestAggregateStore_LoadEvents_MismatchedEventType(t *testing.T) {
 }
 
 func TestAggregateStore_SaveEvents(t *testing.T) {
+	t.Parallel()
+
 	store, eventStore := createStore(t)
 
 	ctx := context.Background()
@@ -222,6 +232,8 @@ func TestAggregateStore_SaveEvents(t *testing.T) {
 }
 
 func TestAggregateStore_AggregateNotRegistered(t *testing.T) {
+	t.Parallel()
+
 	store, _ := createStore(t)
 
 	ctx := context.Background()

diff --git a/aggregatestore/model/aggregatestore_test.go b/aggregatestore/model/aggregatestore_test.go
@@ -27,6 +27,8 @@ import (
 )
 
 func TestNewAggregateStore(t *testing.T) {
+	t.Parallel()
+
 	repo := &mocks.Repo{}
 	bus := &mocks.EventBus{
 		Events: make([]eh.Event, 0),
@@ -50,6 +52,8 @@ func TestNewAggregateStore(t *testing.T) {
 }
 
 func TestAggregateStore_LoadNotFound(t *testing.T) {
+	t.Parallel()
+
 	store, repo, _ := createStore(t)
 
 	ctx := context.Background()
@@ -66,6 +70,8 @@ func TestAggregateStore_LoadNotFound(t *testing.T) {
 }
 
 func TestAggregateStore_Load(t *testing.T) {
+	t.Parallel()
+
 	store, repo, _ := createStore(t)
 
 	ctx := context.Background()
@@ -92,6 +98,8 @@ func TestAggregateStore_Load(t *testing.T) {
 }
 
 func TestAggregateStore_Load_InvalidAggregate(t *testing.T) {
+	t.Parallel()
+
 	store, repo, _ := createStore(t)
 
 	ctx := context.Background()
@@ -114,6 +122,8 @@ func TestAggregateStore_Load_InvalidAggregate(t *testing.T) {
 }
 
 func TestAggregateStore_Save(t *testing.T) {
+	t.Parallel()
+
 	store, repo, _ := createStore(t)
 
 	ctx := context.Background()
@@ -139,6 +149,8 @@ func TestAggregateStore_Save(t *testing.T) {
 }
 
 func TestAggregateStore_SaveWithPublish(t *testing.T) {
+	t.Parallel()
+
 	store, repo, bus := createStore(t)
 
 	ctx := context.Background()

diff --git a/codec/bson/codec_test.go b/codec/bson/codec_test.go
@@ -22,6 +22,8 @@ import (
 )
 
 func TestEventCodec(t *testing.T) {
+	t.Parallel()
+
 	c := &EventCodec{}
 	expectedBytes, err := base64.StdEncoding.DecodeString("4QEAAAJldmVudF90eXBlAAsAAABDb2RlY0V2ZW50AANkYXRhAAwBAAAIYm9vbAABAnN0cmluZwAHAAAAc3RyaW5nAAFudW1iZXIAAAAAAAAARUAEc2xpY2UAFwAAAAIwAAIAAABhAAIxAAIAAABiAAADbWFwABQAAAACa2V5AAYAAAB2YWx1ZQAACXRpbWUAgDVT4CQBAAAJdGltZXJlZgCANVPgJAEAAApudWxsdGltZQADc3RydWN0AC8AAAAIYm9vbAABAnN0cmluZwAHAAAAc3RyaW5nAAFudW1iZXIAAAAAAAAARUAAA3N0cnVjdHJlZgAvAAAACGJvb2wAAQJzdHJpbmcABwAAAHN0cmluZwABbnVtYmVyAAAAAAAAAEVAAApudWxsc3RydWN0AAAJdGltZXN0YW1wAIA1U+AkAQAAAmFnZ3JlZ2F0ZV90eXBlAAoAAABBZ2dyZWdhdGUAAl9pZAAlAAAAMTBhN2VjMGYtN2YyYi00NmY1LWJjYTEtODc3YjZlMzNjOWZkABB2ZXJzaW9uAAEAAAADbWV0YWRhdGEAEgAAAAFudW0AAAAAAAAARUAAA2NvbnRleHQAHgAAAAJjb250ZXh0X29uZQAIAAAAdGVzdHZhbAAAAA==")
 	if err != nil {

diff --git a/codec/json/codec_test.go b/codec/json/codec_test.go
@@ -22,6 +22,8 @@ import (
 )
 
 func TestEventCodec(t *testing.T) {
+	t.Parallel()
+
 	c := &EventCodec{}
 	expectedBytes := strings.ReplaceAll(strings.ReplaceAll(strings.ReplaceAll(`
 	{

diff --git a/command_test.go b/command_test.go
@@ -22,6 +22,8 @@ import (
 )
 
 func TestCreateCommand(t *testing.T) {
+	t.Parallel()
+
 	_, err := CreateCommand(TestCommandRegisterType)
 	if !errors.Is(err, ErrCommandNotRegistered) {
 		t.Error("there should be a command not registered error:", err)
@@ -39,6 +41,8 @@ func TestCreateCommand(t *testing.T) {
 }
 
 func TestRegisterCommandEmptyName(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: attempt to register empty command type" {
 			t.Error("there should have been a panic:", r)
@@ -48,6 +52,8 @@ func TestRegisterCommandEmptyName(t *testing.T) {
 }
 
 func TestRegisterCommandNil(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: created command is nil" {
 			t.Error("there should have been a panic:", r)
@@ -57,6 +63,8 @@ func TestRegisterCommandNil(t *testing.T) {
 }
 
 func TestRegisterCommandTwice(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: registering duplicate types for \"TestCommandRegisterTwice\"" {
 			t.Error("there should have been a panic:", r)
@@ -67,6 +75,8 @@ func TestRegisterCommandTwice(t *testing.T) {
 }
 
 func TestUnregisterCommandEmptyName(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: attempt to unregister empty command type" {
 			t.Error("there should have been a panic:", r)
@@ -76,6 +86,8 @@ func TestUnregisterCommandEmptyName(t *testing.T) {
 }
 
 func TestUnregisterCommandTwice(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: unregister of non-registered type \"TestCommandUnregisterTwice\"" {
 			t.Error("there should have been a panic:", r)

diff --git a/commandhandler/aggregate/commandhandler_test.go b/commandhandler/aggregate/commandhandler_test.go
@@ -26,6 +26,8 @@ import (
 )
 
 func TestNewCommandHandler(t *testing.T) {
+	t.Parallel()
+
 	store := &mocks.AggregateStore{
 		Aggregates: make(map[uuid.UUID]eh.Aggregate),
 	}
@@ -47,6 +49,8 @@ func TestNewCommandHandler(t *testing.T) {
 }
 
 func TestCommandHandler(t *testing.T) {
+	t.Parallel()
+
 	a, h, _ := createAggregateAndHandler(t)
 
 	ctx := context.WithValue(context.Background(), "testkey", "testval")
@@ -68,6 +72,8 @@ func TestCommandHandler(t *testing.T) {
 }
 
 func TestCommandHandler_AggregateNotFound(t *testing.T) {
+	t.Parallel()
+
 	store := &mocks.AggregateStore{
 		Aggregates: map[uuid.UUID]eh.Aggregate{},
 	}
@@ -90,6 +96,8 @@ func TestCommandHandler_AggregateNotFound(t *testing.T) {
 }
 
 func TestCommandHandler_ErrorInHandler(t *testing.T) {
+	t.Parallel()
+
 	a, h, _ := createAggregateAndHandler(t)
 
 	commandErr := errors.New("command error")
@@ -109,6 +117,8 @@ func TestCommandHandler_ErrorInHandler(t *testing.T) {
 }
 
 func TestCommandHandler_ErrorWhenSaving(t *testing.T) {
+	t.Parallel()
+
 	a, h, store := createAggregateAndHandler(t)
 
 	saveErr := errors.New("save error")
@@ -124,6 +134,8 @@ func TestCommandHandler_ErrorWhenSaving(t *testing.T) {
 }
 
 func TestCommandHandler_NoHandlers(t *testing.T) {
+	t.Parallel()
+
 	_, h, _ := createAggregateAndHandler(t)
 
 	cmd := &mocks.Command{

diff --git a/commandhandler/bus/commandhandler_test.go b/commandhandler/bus/commandhandler_test.go
@@ -26,6 +26,8 @@ import (
 )
 
 func TestCommandHandler(t *testing.T) {
+	t.Parallel()
+
 	bus := NewCommandHandler()
 	if bus == nil {
 		t.Fatal("there should be a bus")

diff --git a/context_test.go b/context_test.go
@@ -20,6 +20,8 @@ import (
 )
 
 func TestContextMarshaler(t *testing.T) {
+	t.Parallel()
+
 	if len(contextMarshalFuncs) != 1 {
 		t.Error("there should be one context marshaler")
 	}
@@ -46,6 +48,8 @@ func TestContextMarshaler(t *testing.T) {
 }
 
 func TestContextUnmarshaler(t *testing.T) {
+	t.Parallel()
+
 	if len(contextUnmarshalFuncs) != 1 {
 		t.Error("there should be one context marshaler")
 	}

diff --git a/event_test.go b/event_test.go
@@ -24,6 +24,8 @@ import (
 )
 
 func TestNewEvent(t *testing.T) {
+	t.Parallel()
+
 	timestamp := time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC)
 	event := NewEvent(TestEventType, &TestEventData{"event1"}, timestamp)
 	if event.EventType() != TestEventType {
@@ -85,6 +87,8 @@ func TestNewEvent(t *testing.T) {
 }
 
 func TestCreateEventData(t *testing.T) {
+	t.Parallel()
+
 	data, err := CreateEventData(TestEventRegisterType)
 	if !errors.Is(err, ErrEventDataNotRegistered) {
 		t.Error("there should be a event not registered error:", err)
@@ -109,6 +113,8 @@ func TestCreateEventData(t *testing.T) {
 }
 
 func TestRegisterEventEmptyName(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: attempt to register empty event type" {
 			t.Error("there should have been a panic:", r)
@@ -120,6 +126,8 @@ func TestRegisterEventEmptyName(t *testing.T) {
 }
 
 func TestRegisterEventTwice(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: registering duplicate types for \"TestEventRegisterTwice\"" {
 			t.Error("there should have been a panic:", r)
@@ -134,6 +142,8 @@ func TestRegisterEventTwice(t *testing.T) {
 }
 
 func TestUnregisterEventEmptyName(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: attempt to unregister empty event type" {
 			t.Error("there should have been a panic:", r)
@@ -143,6 +153,8 @@ func TestUnregisterEventEmptyName(t *testing.T) {
 }
 
 func TestUnregisterEventTwice(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil || r != "eventhorizon: unregister of non-registered type \"TestEventUnregisterTwice\"" {
 			t.Error("there should have been a panic:", r)

diff --git a/eventbus/local/eventbus_test.go b/eventbus/local/eventbus_test.go
@@ -23,9 +23,7 @@ import (
 
 // NOTE: Not named "Integration" to enable running with the unit tests.
 func TestAddHandler(t *testing.T) {
-	if testing.Short() {
-		t.Skip("skipping integration test")
-	}
+	t.Parallel()
 
 	bus := NewEventBus()
 	if bus == nil {
@@ -37,6 +35,8 @@ func TestAddHandler(t *testing.T) {
 
 // NOTE: Not named "Integration" to enable running with the unit tests.
 func TestEventBus(t *testing.T) {
+	t.Parallel()
+
 	group := NewGroup()
 	if group == nil {
 		t.Fatal("there should be a group")